~petersanchez

Los Angeles, CA

https://www.petersanchez.com

LA, CA USA - Managua, Nicaragua

~petersanchez/blog-discussion

~petersanchez/public-inbox

View more

Recent activity

Re: [PATCH links] Adding Delete buttons on bookmark and note Detail and Edit views. 9 days ago

From Peter Sanchez to ~netlandish/links-dev

Applied.

To git@git.code.netlandish.com:~netlandish/links
   a484451..155fc39  master -> master

[PATCH links] Adding Delete buttons on bookmark and note Detail and Edit views. 9 days ago

From Peter Sanchez to ~netlandish/links-dev

Implements: https://todo.code.netlandish.com/~netlandish/links/120
Changelog-updated: Add Delete buttons to bookmark/note detail and edit
  views.
---
 core/routes.go             | 4 ++++
 templates/link_create.html | 3 +++
 templates/link_detail.html | 1 +
 templates/note_create.html | 3 +++
 4 files changed, 11 insertions(+)

diff --git a/core/routes.go b/core/routes.go
index 2677123..f34443b 100644
--- a/core/routes.go
+++ b/core/routes.go
[message trimmed]

Re: [PATCH links] Allow removal of all tags from a bookmark, note, listing or short url. 9 days ago

From Peter Sanchez to ~netlandish/links-dev

Applied.

To git@git.code.netlandish.com:~netlandish/links
   babd2b9..a484451  master -> master

[PATCH links] Allow removal of all tags from a bookmark, note, listing or short url. 9 days ago

From Peter Sanchez to ~netlandish/links-dev

Fixes: https://todo.code.netlandish.com/~netlandish/links/117
Changelog-fixed: Issue blocking the removal of ALL tags from an object.
---
 api/api_test.go               |  81 +++++++++++++-
 api/graph/schema.resolvers.go | 204 +++++++++++++++++++++-------------
 2 files changed, 204 insertions(+), 81 deletions(-)

diff --git a/api/api_test.go b/api/api_test.go
index d098661..b0125bd 100644
--- a/api/api_test.go
+++ b/api/api_test.go
@@ -3346,7 +3346,7 @@ func TestAPI(t *testing.T) {
		opA.Var("title", "Link A isolation")
		opA.Var("url", "https://example.com/link-a-isolation")
[message trimmed]

Re: [PATCH links] Fixing bug where removing a tag will remove it across multiple bookmarks, listings and short links. 9 days ago

From Peter Sanchez to ~netlandish/links-dev

Applied.

To git@git.code.netlandish.com:~netlandish/links
   c334752..babd2b9  master -> master

[PATCH links] Fixing bug where removing a tag will remove it across multiple bookmarks, listings and short links. 9 days ago

From Peter Sanchez to ~netlandish/links-dev

Fixes: https://todo.code.netlandish.com/~netlandish/links/118
Changelog-fixed: Tag removal bug where tags are incorrectly removed from
  multiple objects.
---
This is an embarassing bug to have missed. Added tests as well for these
cases

 api/api_test.go               | 113 ++++++++++++++++++++++++++++++++++
 api/graph/schema.resolvers.go |   6 +-
 models/tag_link_shorts.go     |   7 ++-
 models/tag_links.go           |   7 ++-
 models/tag_listing.go         |   7 ++-
 5 files changed, 131 insertions(+), 9 deletions(-)
[message trimmed]

Re: [PATCH links] Fix ISE when toggling a note as read/unread. 19 days ago

From Peter Sanchez to ~netlandish/links-dev

Applied.

To git@git.code.netlandish.com:~netlandish/links
   1fdf348..c334752  master -> master

[PATCH links] Fix ISE when toggling a note as read/unread. 19 days ago

From Peter Sanchez to ~netlandish/links-dev

Changelog-fixed: Bug in GraphQL resolver not allowing the toggling of
  the unread flag for notes
---
 api/graph/schema.resolvers.go | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/api/graph/schema.resolvers.go b/api/graph/schema.resolvers.go
index a1584ca..3c28046 100644
--- a/api/graph/schema.resolvers.go
+++ b/api/graph/schema.resolvers.go
@@ -749,12 +749,6 @@ func (r *mutationResolver) UpdateLink(ctx context.Context, input *model.UpdateLi
	}

	if input.Unread != nil {
[message trimmed]

Re: [PATCH links] Adding `imageUrl` to relevant GraphQL types to make it easier to fetch images from their individual hosting environments. 24 days ago

From Peter Sanchez to ~netlandish/links-dev

Applied.

To git@git.code.netlandish.com:~netlandish/links
   d4cc8e5..1fdf348  master -> master

Re: [PATCH links] Removing test as it's not needed. The functionality of `ValidDomain` is covered in another test, which is what we care about. 24 days ago

From Peter Sanchez to ~netlandish/links-dev

Applied.

To git@git.code.netlandish.com:~netlandish/links
   04b88f7..d4cc8e5  master -> master