Received: from mail.netlandish.com (mail.netlandish.com [174.136.98.166]) by code.netlandish.com (Postfix) with ESMTP id 1279981244 for <~petersanchez/public-inbox@lists.code.netlandish.com>; Wed, 23 Dec 2020 06:26:48 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.210.182; helo=mail-pf1-f182.google.com; envelope-from=peter@netlandish.com; receiver= Authentication-Results: mail.netlandish.com; dkim=pass (2048-bit key; unprotected) header.d=netlandish-com.20150623.gappssmtp.com header.i=@netlandish-com.20150623.gappssmtp.com header.b=jkBDfEej Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mail.netlandish.com (Postfix) with ESMTP id 166F2152FB5 for <~petersanchez/public-inbox@lists.code.netlandish.com>; Wed, 23 Dec 2020 06:26:45 +0000 (UTC) Received: by mail-pf1-f182.google.com with SMTP id w6so9827705pfu.1 for <~petersanchez/public-inbox@lists.code.netlandish.com>; Tue, 22 Dec 2020 22:26:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netlandish-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SmrUwXoGa5353nCUnVBYDJoUdWtd0gHqbKbofKj8O2g=; b=jkBDfEejQjUFXY/+F8DPJAjFgOb24xCRSqU9gIBqUVwxijcI7wsQrpnw1cKeH0PhzD Z5ouY8jneP/C9WXrWoGNWZ2B3VCq+UCLMgRg/UcpiM5/fkEDU+qAzvka7f5/p9b9dswT FUIk41yG9Y4zg9viQZT/cV/Dz8qMzU6ywaGBVf96KtE/Zo2UbBmzncBnDXJHiw/iGfkj 5XYVMqedN6AxTfZ5EyUMt+TWz3E1Ey2vl1auVfJbr6PIQTb9NsFHW2TPmK9GMZih8wx9 3aSFWGXKmVUvFUPhhqfE2HVz0OcpnfksqcaYjQO4iFgaUekMtWq3/G4sBm0/QDy0YBrr v1Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SmrUwXoGa5353nCUnVBYDJoUdWtd0gHqbKbofKj8O2g=; b=dwVArGFIEZ2cmdoUasZhOs4JCEJD5vvJCnQjZJN36opqTwB4tdHxwNXQjIysKNBGiA 4qw1Fz0gQC2qLoHLfFGXA0sFUSiWcsR7639KalaDkyEdm8VXF2d0bC8U8UaIzyJ2G7Ln 3t/B/lltVkRxdyX33dgfF0hyJfplTBacV+Hx+00nmZUTAF+FQtk597BGEgvz4Z/096cZ Ex8Mg4NgJ0hvdgjzB4BcH2PXUHKPHYYp/gN6ktyPb6mmqcgbX/y1D1TgKiSXImOrJA3h RgefNdT84f4yWh0LVF9C3gKPHjc08yd3jsFEK4e8rhbsfrz3GbWjyQ86y+WVpZhce3UF vk7g== X-Gm-Message-State: AOAM533rP6Fl64uFi1PDwCqwvDX02y5Y//ycm/qswvDiiuUVzYUCw643 +n4A1XyaJzpvpkEap1gH5r4UMYuN X-Google-Smtp-Source: ABdhPJwdqvkmvK/VFbnMbn7i373eIZx2qnXQ2p+Z9rfuLXkfvdG1Z8QQcEr5drIy5ocSqybTlZ0+ng== X-Received: by 2002:a65:6a53:: with SMTP id o19mr23064102pgu.212.1608704805159; Tue, 22 Dec 2020 22:26:45 -0800 (PST) Received: from localhost ([47.145.116.220]) by smtp.gmail.com with ESMTPSA id y16sm13872740pgg.20.2020.12.22.22.26.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Dec 2020 22:26:44 -0800 (PST) Date: Tue, 22 Dec 2020 22:26:42 -0800 From: Peter Sanchez To: =?utf-8?B?0JjQu9GM0Y8=?= Cc: ~petersanchez/public-inbox@lists.code.netlandish.com Subject: Re: [PATCH django-impersonate] optimization | preserve request.user laziness Message-ID: <20201223062642.cd6a4wbiy7cvb547@thinkpad> X-PGP-Key: https://petersanchez.com/publickey.txt References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lla3jcitw77buyb2" Content-Disposition: inline In-Reply-To: --lla3jcitw77buyb2 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 12/22, =D0=98=D0=BB=D1=8C=D1=8F wrote: >class ImpersonateMiddleware(MiddlewareMixin): > def process_request(self, request): > _usr =3D request.user # save as local var to prevent infinite rec= ursion > def _get_usr(): > _usr.is_impersonate =3D False > return _usr > > request.user =3D SimpleLazyObject(_get_usr) > request.impersonator =3D None > > if '_impersonate' in request.session and request.user.is_authentic= ated: > .... This has been applied in changeset eed039f473c6 Thanks! --lla3jcitw77buyb2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEkJViJRZ6KPWgtGGig4/80jEiNdEFAl/i4x0ACgkQg4/80jEi NdFakRAAoGyJguyqJmbZZislbsUc64O4+iW1xu2QubVGhttxbXUZx+KTMUx+Z1/K niyY70kPT2P4EqQWHk0V0j9SDCzOd5gxeTHNVegZp1F5Sxkb0ciyuusvFePPeCHR Q1od2XBE5NGtj2PTJlJGiE1USZK+M2dfG5YEAg8mIjTO0X8u7elasCJDNHhMKj2B HhXmNHyYmsXM8umAqUPYLGHpx+fuvKuM1uPmaTke65e6yUcgTO9w5lgimAyC8z/h uRZJR4CuyUjuiYfovt+VMkeve96HYyNJNJiza3qHsdCAcZKPIBJJvqA7NxFPUC+Z YdBe28Ai1lG0nrySI7NhHKO1pMQdND6oXXhQZcEhVGbcqCkOG4fqaZNZhMgOFOio sA7Obo9e3c+9tAny9b25sWWBb3GfrOS7GAiP/926iBsevvizxQz58taE1jiTeuLx aNTB/cMsu1BXzlSKzoLFKrR72quoih0MwcbX7YgLH+lZTTLagUF4xo12j7fmjLwh UC1jj8CXwC4NYapfk8gWh7xSQvmgL74y4uC7N0X22S43zd2f6/9O3TOD1f6J4y8C vUGbGuDs/82CfE33ycsXVZvcSb9Qkaw12xbJwKnec8dCgEW/c231deTddwkTzUS5 FnzIIk9RwcTkO8LeByt8ub7eN2nHJYTYmKi/Z4k0PAE6/PNGshg= =454K -----END PGP SIGNATURE----- --lla3jcitw77buyb2--