Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.217.54; helo=mail-vs1-f54.google.com; envelope-from=peter@netlandish.com; receiver=<UNKNOWN> 
Date: Tue, 10 Oct 2023 08:37:40 -0600
From: Peter Sanchez <peter@netlandish.com>
To: Hugo Rodger-Brown <hugo@yunojuno.com>
Cc: ~petersanchez/public-inbox@lists.code.netlandish.com
Subject: Re: [PATCH django-impersonate] Add support for Django 5.0 (pre)
Message-ID: <20231010143740.eyuf2t7a6d3b7mw7@thinkpad.my.domain>
References: <4abfc208f5ac1289c52f.1687947872@C17FQ18CQ6L4>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <4abfc208f5ac1289c52f.1687947872@C17FQ18CQ6L4>

>diff --git a/impersonate/compat.py b/impersonate/compat.py
>new file mode 100644
>--- /dev/null
>+++ b/impersonate/compat.py
>@@ -0,0 +1,12 @@
>+try:
>+    from django.urls import reverse
>+except ImportError:
>+    from django.core.urlresolvers import reverse
>+
>+
>+# timezone.utc removed in Django 5
>+try:
>+    from django.utils.timezone import utc
>+except ImportError:
>+    from zoneinfo import ZoneInfo
>+    utc = ZoneInfo("UTC")

This doesn't actually define `timezone` which is imported in other
files. Am I missing something here? Tests can't possibly pass as it is
now.

PS, sorry for the delay in reviewing this.